SourceDetector

[Steve Purkis]

On 5 Sep 2009, at 04:23, David E. Wheeler wrote:

> On Aug 31, 2009, at 10:52 AM, Steve Purkis wrote:
>
>> All major refactoring is complete so I figured it was time to open  
>> it up to another round of feedback.
>
> Awesome, well done. I was able to fork the project and, in about  
> three hours, add a new detector for pgTAP, including tests!
>
>  http://github.com/theory/Test-Harness/commit/8da53e4adeefc4a32bf3ce0bad1b0e65f6bef965
>
> I especially like that I was able to do it with just two methods in  
> the subclass. Nice!

Nice - 3h to write a new detector/handler including tests is pretty  
good!

Glad you're happy with the API.  It's definitely a lot more simple  
now, thanks to your suggestions for a better API.


>> 	Decide whether or not to rename 'SourceDetector' --> 'SourceHandler'
> Makes sense to me

Good; that's next on the list.


>> 	Update TAP::Parser & Subclassing docs
> Yep. I think It should be pretty simple to document adding a new  
> detector. I mean handler.

I've done a lot as I went, so hopefully it's almost ready for review.   
If someone feels like whipping up some examples for M::B & EU::MM for  
TAP::Harness, that'd be really helpful.


>> 	Integrate into App::Prove
> That should be pretty straight-forward, yes?

That's done now.  You can now do:

perl -Ilib bin/prove --source_handler Foo --source_hander Bar t
perl -Ilib bin/prove --source_handler 'File: {extensions: [.1]}' t/ 
source_tests/source.1


> Thanks again, Steve, this is awesome.

No problem - one last push, and we should finally be able to get this  
out the door.

Cheers,
-Steve