GitHub

[Andy Armstrong]

On 2 Jun 2009, at 17:23, David Golden wrote:
> Immediate reactions:
>
> (1) please, please, don't use double-dashes in the name, that's very
> anti-convention and will be constantly mistyped.

OK :)

> (2) branches -- you seem to have branches for each project that point
> to the same commit. Those should be eliminated.

OK - huge gap in my understanding of git here. Surely a git branch  
contains everything in the project, no? I didn't think there was a way  
to have git know that the different subdirectories are different  
projects. What should the branches look like?

> Likewise, you have
> some branches that appear to have been deleted in the past and have
> been resurrected.  See "git branch -av" for list of branches plus last
> commit id/message.

That'll be something to do with the script that munges the svn repo.  
I'll see if I can find out where they're coming from.

> More generally -- if these branches are all legacy and have been
> merged into trunk or abandoned, you might just leave them out of the
> conversion entirely.  I'd only keep branches if you expect future
> commits on the branch.

Yeah, they just all got sucked in. I assumed we'd just delete them  
from git.

> (3) tags -- it looks like you've got 'tft-0.1', etc. for subproject
> tags.  I would suggest following the same format for Test-Harness
> commits or possibly expanding them all out fully:
> "Test-More-Diagnostic-0.2", "Test-Harness-3.17", etc.  That will
> minimize any chance of confusion over what the tags represent.


OK, willfix.

Thanks :)

-- 
Andy Armstrong, Hexten