Release this weekend?
Nicholas Clark
nick at ccl4.org
Sat Sep 13 13:48:38 UTC 2008
On Sat, Sep 13, 2008 at 02:24:54PM +0100, Andy Armstrong wrote:
> David has found and fixed a problem with our handling of PERL5OPT.
> It'd be good to ship 3.14 soon so that he can take advantage of his
> fix and release a new CPAN::Reporter.
>
> We were waiting for a Module::Build release because our output
> formatting changes broke the M::B test suite. The M::B release is
> coming soon but I think we should ship 3.14 even sooner.
>
> Once 3.14 is shipped I'll restore the formatting changes.
>
> Any objections to a release in the next few hours? I expect 3.14 to be
> a short lived release - we'll probably go for 3.15 in 1 to 2 weeks.
I like this plan. It will be integrated into blead very quickly.
I think you also need to temporarily revert this change:
$ svn log -r1185:1185 https://svn.hexten.net/tapx/trunk
------------------------------------------------------------------------
r1185 | nicholas | 2008-08-30 15:17:19 +0100 (Sat, 30 Aug 2008) | 4 lines
Given that the new tidier output supplies a space after the "...", we don't
need a leading space in every failure message to separate it from the dots.
Before this change there were two spaces, and the failure messages did not line
up with the OKs.
------------------------------------------------------------------------
$ svn diff -r1184:1185 https://svn.hexten.net/tapx/trunk
Index: lib/TAP/Formatter/Console/Session.pm
===================================================================
--- lib/TAP/Formatter/Console/Session.pm (revision 1184)
+++ lib/TAP/Formatter/Console/Session.pm (revision 1185)
@@ -305,18 +305,18 @@
if ( my $exit = $parser->exit ) {
my $wstat = $parser->wait;
my $status = sprintf( "%d (wstat %d, 0x%x)", $exit, $wstat, $wstat );
- $formatter->_failure_output(" Dubious, test returned $status\n");
+ $formatter->_failure_output("Dubious, test returned $status\n");
}
if ( $failed == 0 ) {
$formatter->_failure_output(
$total
- ? " All $total subtests passed "
- : ' No subtests run '
+ ? "All $total subtests passed "
+ : 'No subtests run '
);
}
else {
- $formatter->_failure_output(" Failed $failed/$total subtests ");
+ $formatter->_failure_output("Failed $failed/$total subtests ");
if ( !$total ) {
$formatter->_failure_output("\nNo tests run!");
}
[Is there a single svn command which would do the above? Something like
perforce describe]
Nicholas Clark
More information about the tapx-dev
mailing list