Release this weekend?
Andy Armstrong
andy at hexten.net
Sat Sep 13 13:24:54 UTC 2008
David has found and fixed a problem with our handling of PERL5OPT.
It'd be good to ship 3.14 soon so that he can take advantage of his
fix and release a new CPAN::Reporter.
We were waiting for a Module::Build release because our output
formatting changes broke the M::B test suite. The M::B release is
coming soon but I think we should ship 3.14 even sooner.
Once 3.14 is shipped I'll restore the formatting changes.
Any objections to a release in the next few hours? I expect 3.14 to be
a short lived release - we'll probably go for 3.15 in 1 to 2 weeks.
Begin forwarded message:
> From: andy at hexten.net
> Date: 13 September 2008 14:20:32 BST
> To: tapx-commit at hexten.net
> Subject: [1213] Temporarily revert the formatting changes so we can
> push a release to fix the bug DGOLDEN just fixed .
> Reply-To: tapx-dev at hexten.net
>
> Revision
> 1213
> Author
> andy
> Date
> 2008-09-13 13:20:31 +0000 (Sat, 13 Sep 2008)
> Log Message
>
> Temporarily revert the formatting changes so we can push a release
> to fix the bug DGOLDEN just fixed. Once we've made a release I'll
> reinstate them.
> Modified Paths
>
> trunk/Changes
> trunk/lib/TAP/Formatter/Console.pm
> trunk/lib/TAP/Harness.pm
> trunk/t/harness.t
> Diff
>
> Modified: trunk/Changes (1212 => 1213)
> --- trunk/Changes 2008-09-13 13:12:24 UTC (rev 1212)
> +++ trunk/Changes 2008-09-13 13:20:31 UTC (rev 1213)
> @@ -3,8 +3,6 @@
>
> 3.14
> - Created a proper (ha!) API for prove state results and
> tests.
> - - After discussion with Andy, agreed to clean up the test
> output
> - somewhat. t/foo.....ok becomes t/foo ... ok
> - Added --count and --nocount options to prove to control X/
> Y display
> while running tests.
> - Added 'fresh' state option to run test scripts that have
> been
> Modified: trunk/lib/TAP/Formatter/Console.pm (1212 => 1213)
> --- trunk/lib/TAP/Formatter/Console.pm 2008-09-13 13:12:24 UTC (rev
> 1212)
> +++ trunk/lib/TAP/Formatter/Console.pm 2008-09-13 13:20:31 UTC (rev
> 1213)
> @@ -219,8 +219,7 @@
> sub _format_name {
> my ( $self, $test ) = @_;
> my $name = $test;
> - my $periods = '.' x ( $self->_longest + 2 - length $test );
> - $periods = " $periods ";
> + my $periods = '.' x ( $self->_longest + 4 - length $test );
>
> if ( $self->timer ) {
> my $stamp = $self->_format_now();
> Modified: trunk/lib/TAP/Harness.pm (1212 => 1213)
> --- trunk/lib/TAP/Harness.pm 2008-09-13 13:12:24 UTC (rev 1212)
> +++ trunk/lib/TAP/Harness.pm 2008-09-13 13:20:31 UTC (rev 1213)
> @@ -623,10 +623,23 @@
> sub _add_descriptions {
> my $self = shift;
>
> - # Turn unwrapped scalars into anonymous arrays and copy the
> name as
> - # the description for tests that have only a name.
> - return map { @$_ == 1 ? [ $_->[0], $_->[0] ] : $_ }
> - map { 'ARRAY' eq ref $_ ? $_ : [$_] } @_;
> + # First transformation: turn scalars into single element arrays
> + my @tests = map { 'ARRAY' eq ref $_ ? $_ : [$_] } @_;
> +
> + # Work out how many different extensions we have
> + my %ext;
> + for my $test (@tests) {
> + $ext{$1}++ if $test->[0] =~ /\.(\w+)$/;
> + }
> +
> + for my $test (@tests) {
> + if ( @$test == 1 ) {
> + $test->[1] = $test->[0];
> + $test->[1] =~ s/\.\w+$//
> + if keys %ext <= 1;
> + }
> + }
> + return @tests;
> }
>
> =head3 C<make_scheduler>
> Modified: trunk/t/harness.t (1212 => 1213)
> --- trunk/t/harness.t 2008-09-13 13:12:24 UTC (rev 1212)
> +++ trunk/t/harness.t 2008-09-13 13:20:31 UTC (rev 1213)
> @@ -113,7 +113,7 @@
> chomp(@output);
>
> my @expected = (
> - "$source_tests/harness ..",
> + "$source_tests/harness....",
> '1..1',
> '[[reset]]',
> 'ok 1 - this is a test',
> @@ -144,7 +144,7 @@
> chomp(@output);
>
> @expected = (
> - 'My Nice Test ..',
> + 'My Nice Test....',
> '1..1',
> '[[reset]]',
> 'ok 1 - this is a test',
> @@ -177,13 +177,13 @@
> chomp(@output);
>
> @expected = (
> - 'My Nice Test ........',
> + 'My Nice Test..........',
> '1..1',
> '[[reset]]',
> 'ok 1 - this is a test',
> '[[reset]]',
> 'ok',
> - 'My Nice Test Again ..',
> + 'My Nice Test Again....',
> '1..1',
> '[[reset]]',
> 'ok 1 - this is a test',
> @@ -209,7 +209,7 @@
>
> chomp(@output);
> @expected = (
> - "$source_tests/harness ..",
> + "$source_tests/harness....",
> 'ok',
> 'All tests successful.',
> );
> @@ -261,7 +261,7 @@
> @output = @output[ 0 .. 9 ];
>
> @expected = (
> - "$source_tests/harness_failure ..",
> + "$source_tests/harness_failure....",
> '1..2',
> '[[reset]]',
> 'ok 1 - this is a test',
> @@ -302,7 +302,7 @@
> $status = pop @output;
> $summary = pop @output;
> @expected = (
> - "$source_tests/harness_failure ..",
> + "$source_tests/harness_failure....",
> 'Failed 1/2 subtests',
> 'Test Summary Report',
> '-------------------',
> @@ -349,7 +349,7 @@
> chomp(@output);
>
> @expected = (
> - "$source_tests/harness_directives ..",
> + "$source_tests/harness_directives....",
> 'not ok 2 - we have a something # TODO some output',
> "ok 3 houston, we don't have liftoff # SKIP no funding",
> 'ok',
> @@ -407,7 +407,7 @@
> @summary = @output[ 12 .. ( $#output - 1 ) ];
> @output = @output[ 0 .. 11 ];
> @expected = (
> - "$source_tests/harness_badtap ..",
> + "$source_tests/harness_badtap....",
> '1..2',
> '[[reset]]',
> 'ok 1 - this is a test',
> @@ -461,7 +461,7 @@
> chomp(@output);
>
> @expected = (
> - "$source_tests/harness_failure ..",
> + "$source_tests/harness_failure....",
> 'not ok 2 - this is another test',
> 'Failed 1/2 subtests',
> 'Test Summary Report',
> @@ -487,7 +487,7 @@
> chomp(@output);
>
> @expected = (
> - "$sample_tests/no_output ..",
> + "$sample_tests/no_output....",
> 'No subtests run',
> 'Test Summary Report',
> '-------------------',
> @@ -859,15 +859,15 @@
> { name => 'all the same',
> input => [ 'foo.t', 'bar.t', 'fletz.t' ],
> output => [
> - [ 'foo.t', 'foo.t' ], [ 'bar.t', 'bar.t' ],
> - [ 'fletz.t', 'fletz.t' ]
> + [ 'foo.t', 'foo' ], [ 'bar.t', 'bar' ],
> + [ 'fletz.t', 'fletz' ]
> ],
> },
> { name => 'all the same, already cooked',
> input => [ 'foo.t', [ 'bar.t', 'brip' ], 'fletz.t' ],
> output => [
> - [ 'foo.t', 'foo.t' ], [ 'bar.t', 'brip' ],
> - [ 'fletz.t', 'fletz.t' ]
> + [ 'foo.t', 'foo' ], [ 'bar.t', 'brip' ],
> + [ 'fletz.t', 'fletz' ]
> ],
> },
> { name => 'different exts',
> _______________________________________________
> tapx-commit mailing list
> tapx-commit at hexten.net
> http://hexten.net/mailman/listinfo/tapx-commit
--
Andy Armstrong, Hexten
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.hexten.net/pipermail/tapx-dev/attachments/20080913/4fbc06c5/attachment-0001.htm
More information about the tapx-dev
mailing list