[BUG] --state used when it shouldn't be

[Ovid]

--- Andy Armstrong <andy at hexten.net> wrote:

> On 3 Jan 2008, at 10:57, Ovid wrote:
> > It seems to me that if I run prove with an explicit set of tests,
> only
> > those tests should be run, regardless of what's in my .proverc.
> 
> Um. Yes, maybe :)
> 
> There's a reason for the current behaviour - it's so that if you do
> 
> $ prove --state=hot,fast,save -r t
> 
> it automatically adds newly created tests; --state only knows about  
> existing tests.
> 
> Suggestions welcome for a cleaner way of handling that.

I've been thinking about this and there are all sorts of pitfalls, but
perhaps if we distinguish between files and directories?  If someone
specifies files (and particularly the common case of "prove
$test_i_am_currently_working_on"), .proverc is not consulted, but if
they specify directories, it is? If they specify both, throw an
exception (kidding!)

The problem is that I and other developers here are repeatedly getting
frustrated by the "hey, it ran a whole bunch more tests than I wanted
it to!"  One developer has already decided to drop his .proverc file
since it now gets in the way more than it helps.

Cheers,
Ovid
 
> > On a different note, we are now running one project's tests in
> three
> > directories (well, we're about to create the third):
> >
> >  t/
> >  test/aggregate
> >  test/standards
> >
> > Should the .prove file group tests by directory instead of assuming
> > that all tests which are run will be run every time?  In other
> words,
> > when I run:
> >
> >  prove -rl --state=hot,fast,save t/
> >
> > And:
> >
> >  prove -rl --state=hot,fast,save test/standards
> >
> > I won't those to run different sets of tests (obviously), even
> though
> > I'm running them from the same directory :)
> 
> 
> Well if we can fix the first problem then something like that sounds 
> 
> reasonable too :)
> 
> -- 
> Andy Armstrong, Hexten
> 
> 
> 
> 
> 


--
Buy the book  - http://www.oreilly.com/catalog/perlhks/
Perl and CGI  - http://users.easystreet.com/ovid/cgi_course/
Personal blog - http://publius-ovidius.livejournal.com/
Tech blog     - http://use.perl.org/~Ovid/journal/