[728] Removed non-portable self testing gubbins from Makefile.PL

[Michael G Schwern]

andy at hexten.net wrote:
> --- trunk/Makefile.PL	2007-10-11 18:09:39 UTC (rev 727)
> +++ trunk/Makefile.PL	2007-10-11 18:20:51 UTC (rev 728)
> @@ -23,26 +23,3 @@
>      $mm_args{LICENSE} = 'perl';
>  }
>  WriteMakefile(%mm_args);
> -
> -{
> -
> -    package MY;
> -
> -    use File::Spec;
> -    use Config;
> -
> -    sub test_via_harness {
> -        my ( $self, $orig_perl, $tests ) = @_;
> -        #die "tests: $tests";
> -
> -        my $perl5lib = join $Config{path_sep},
> -          grep { defined && length } File::Spec->canonpath('lib/'),
> -          $ENV{PERL5LIB};
> -
> -        # yes, maybe this is sneaky, but the test_via_harness is broken
> -        # unless we are meta-compatible
> -        my $perl = 
> -            qq[PERL5LIB=$perl5lib $orig_perl "-Iblib/lib" bin/prove];
> -        return $self->SUPER::test_via_script( $perl, $tests );
> -    }
> -}

That we test ourselves with ourselves is important.

That code did work until it started using prove.  I don't remember why it was
changed.  Something to do with the @INC propagation stuff.  I'll just put it
back to using test_via_harness().


-- 
Stabbing you in the face so you don't have to.