664, 668 - Getopt::Long

[Andy Armstrong]

On 4 Oct 2007, at 20:00, Eric Wilhelm z wrote:
>> We don't have subrefs in the options though...
>
> Yes we do, and plugins will too.

When was that decided?

> Gah!  I get 30 minutes in my sleep to defend my commit?  Please  
> imagine
> that I might have a decent reason and let it stand unless it is
> actually in the way.  I commented this, explained it on the mailing
> list, and tested it against all of our compatibility targets.
>
> The reason for localizing the Getopt::Long::GetOptions() call is  
> pretty
> straightforward.  It separates the declarations of @options from the
> parsing of them, and makes it easier to replace Getopt::Long with
> something non-broken should said non-broken option parser be  
> available.
>
> Please restore these changes.  They test clean against 5.5.4 and allow
> us to avoid explaining in the documentation that the Getopt::Long
> "necessary evil because it is core" borked dependency breaks "perl 5"
> code.

Please explain what the changes are for.

-- 
Andy Armstrong, Hexten