[PATCH] Fix remaining skips for Test::Harness

[Nicholas Clark]

On Thu, Dec 20, 2007 at 11:16:01PM +0000, Andy Armstrong wrote:
> The attached patch against 32680 fixes all the outstanding FIXMEs in  
> T::H's test suite. The entire suite now runs cleanly in core.


lib/Test/Harness/t/compat/test-harness-compat.t doesn't like me, but only when
run under the harness (not standalone, not under TEST) and only on an
unthreaded build. I added some more diagnostics:

./perl harness ../lib/Test/Harness/t/compat/test-harness-compat.t 
../lib/Test/Harness/t/compat/test-harness-compat......5/120 
#   Failed test 'totals match for taint_warn'
#   at ../lib/Test/Harness/t/compat/test-harness-compat.t line 847.
#     Structures begin differing at:
#          $got->{max} = '0'
#     $expected->{max} = '1'
# $VAR1 = [
#           {
#             'files' => 1,
#             'max' => 0,
#             'bonus' => 0,
#             'skipped' => 0,
#             'sub_skipped' => 0,
#             'ok' => 0,
#             'bad' => 1,
#             'good' => 0,
#             'tests' => 1,
#             'todo' => 0
#           },
#           {
#             'files' => 1,
#             'max' => 1,
#             'bonus' => 0,
#             'sub_skipped' => 0,
#             'skipped' => 0,
#             'ok' => 1,
#             'bad' => 0,
#             'good' => 1,
#             'tests' => 1,
#             'todo' => 0
#           }
#         ];

#   Failed test 'failure summary matches for taint_warn'
#   at ../lib/Test/Harness/t/compat/test-harness-compat.t line 848.
#     Structures begin differing at:
#          $got->{lib/sample-tests/taint_warn} = HASH(0x1211918)
#     $expected->{lib/sample-tests/taint_warn} = Does not exist
# $VAR1 = [
#           {
#             'files' => 1,
#             'max' => 0,
#             'bonus' => 0,
#             'skipped' => 0,
#             'sub_skipped' => 0,
#             'ok' => 0,
#             'bad' => 1,
#             'good' => 0,
#             'tests' => 1,
#             'todo' => 0
#           },
#           {
#             'files' => 1,
#             'max' => 1,
#             'bonus' => 0,
#             'sub_skipped' => 0,
#             'skipped' => 0,
#             'ok' => 1,
#             'bad' => 0,
#             'good' => 1,
#             'tests' => 1,
#             'todo' => 0
#           }
#         ];
# Looks like you failed 2 tests of 120.
../lib/Test/Harness/t/compat/test-harness-compat...... Dubious, test returned 2 (wstat 512, 0x200)
 Failed 2/120 subtests

Test Summary Report
-------------------
../lib/Test/Harness/t/compat/test-harness-compat.t (Wstat: 512 Tests: 120 Failed: 2)
  Failed tests:  102-103
  Non-zero exit status: 2
Files=1, Tests=120,  1 wallclock secs ( 0.05 usr  0.00 sys +  0.84 cusr  0.26 csys =  1.15 CPU)
Result: FAIL
Failed 1/1 test programs. 2/120 subtests failed.



This doesn't make sense to me, but I hope that you're able to replicated it
on an unthreaded build.

Nicholas Clark