[tapx-dev] [patch to D::C] coverage testing appears to be fixed

[Leif Eriksen]

No I just CC'd Paul with the fix - I'll try harder tomorrow and hit RT,
but its beddybyes for me now...

L

On Sun, 2007-08-19 at 06:11 -0700, Ovid wrote:
> Code I was working on yesterday also had zero coverage.  This patch
> fixed it.  Is it in RT?  RT appears to be down so I couldn't verify it,
> but I mentioned it in a blog:
> 
>   http://use.perl.org/~Ovid/journal/34152
> 
> Cheers,
> Ovid
> --- Leif Eriksen <leif.eriksen at bigpond.com> wrote:
> 
> > OK I have a patch
> > 
> > --- Devel-Cover-0.61-bad/lib/Devel/Cover/DB.pm  2007-01-11
> > 06:42:48.000000000 +1100
> > +++ Devel-Cover-0.61-good/lib/Devel/Cover/DB.pm 2007-08-12
> > 01:03:18.000000000 +1000
> > @@ -708,7 +708,7 @@
> >              while (my ($criterion, $fc) = each %$f)
> >              {
> >                  my $get = "get_$criterion";
> > -                my $sc  = $st->$get($digests{$digest});
> > +                my $sc  = $st->$get($file);
> >                  # print STDERR "$criterion: ", Dumper $sc, $fc;
> >                  next unless $sc;  # TODO - why?
> >                  my $cc  = $cf->{$criterion} ||= {};
> > 
> > Maybe there is something wrong with the digest entries, but I'll
> > leave
> > that to Paul.
> > 
> > I made this patch to D::C 0.61 and the test harness still passes -
> > this
> > patch actually reverts this line to back how it was in D::C 0.55.
> > 
> > I've CC'd this to Paul, hopefully this patch is helpful.
> > 
> > L
> > 
> > 
> > 
> > _______________________________________________
> > tapx-dev mailing list
> > tapx-dev at hexten.net
> > http://www.hexten.net/mailman/listinfo/tapx-dev
> > cpan: http://search.cpan.org/dist/TAP-Parser/
> > bugs: http://rt.cpan.org/Public/Dist/Display.html?Name=TAP-Parser
> > 
> 
> 
> --
> Buy the book  - http://www.oreilly.com/catalog/perlhks/
> Perl and CGI  - http://users.easystreet.com/ovid/cgi_course/
> Personal blog - http://publius-ovidius.livejournal.com/
> Tech blog     - http://use.perl.org/~Ovid/journal/
> _______________________________________________
> tapx-dev mailing list
> tapx-dev at hexten.net
> http://www.hexten.net/mailman/listinfo/tapx-dev
> cpan: http://search.cpan.org/dist/TAP-Parser/
> bugs: http://rt.cpan.org/Public/Dist/Display.html?Name=TAP-Parser