[tapx-dev] Poosible issue with TAP::Parser::Source::_get_command()

[Andy Armstrong]

On 14 Aug 2007, at 14:23, Ovid wrote:
> That leaves a different problem, though.  It's OK for a derived class
> to extend an interface, but what does it mean to ignore parts of the
> base interface?  This means that TAP::Parser::Source and
> TAP::Parser::Source::Perl have slightly different interfaces and I
> don't feel quite comfortable with that.  This is a code smell and I
> think carefully considering the design is important here.

Yes. I suspect that although source (and now source_file) are setters  
we don't really want anyone to set them via that interface. I don't  
think we really need the sources to be mutable do we? In fact do we  
really source to be public at all?

I think if we can nail down what we believe those accessors are  
actually for (outside of internal use within the class) we might find  
we can get rid of them or provide a better, more consistent interface.

-- 
Andy Armstrong, hexten.net