[tapx-dev] [commit][223] Disabled redundant parsing of test output

andy at hexten.net andy at hexten.net
Fri Aug 10 16:10:36 BST 2007


Revision: 223
Author:   andy
Date:     2007-08-10 16:10:36 +0100 (Fri, 10 Aug 2007)

Log Message:
-----------
Disabled redundant parsing of test output

Modified Paths:
--------------
    trunk/smoke/smoke.pl

Modified: trunk/smoke/smoke.pl
===================================================================
--- trunk/smoke/smoke.pl	2007-08-10 15:05:14 UTC (rev 222)
+++ trunk/smoke/smoke.pl	2007-08-10 15:10:36 UTC (rev 223)
@@ -35,10 +35,10 @@
         script => [
             'yes n | %PERL% Makefile.PL',
             'make',
-            [ 'make test', \&check_test ],
+            'make test',
 
             # Dogfood
-            [ '%PERL% -Ilib bin/runtests -b t/*.t t/compat/*.t', \&check_test ],
+            '%PERL% -Ilib bin/runtests t/*.t t/compat/*.t',
         ],
 
         mailto => 'tapx-dev at hexten.net',
@@ -206,8 +206,8 @@
         my $results = capture_command($cooked);
 
         my $status
-          = $check->($results)
-          ? ( $results->{status} ? 'died' : 'passed' )
+          = ( $results->{status} == 0 && $check->{$results} )
+          ? 'passed'
           : 'failed';
 
         return unless $feedback->( $status, $cooked, $results );
@@ -263,7 +263,8 @@
 }
 
 # Scan test output. Should work with both runtests (TAP::Parser) and
-# prove (Test::Harness)
+# prove (Test::Harness).
+# Not currently used. We probably don't need to parse the test output.
 sub check_test {
     my $results = shift;
 




More information about the tapx-dev mailing list