[tapx-dev] [commit][214] Removed dependencies on Data::Dumper.

[andy at hexten.net]

Revision: 214
Author:   andy
Date:     2007-08-09 19:38:31 +0100 (Thu, 09 Aug 2007)

Log Message:
-----------
Removed dependencies on Data::Dumper.

Modified Paths:
--------------
    trunk/t/020-regression.t
    trunk/t/150-yamlish.t
    trunk/t/160-yamlish-writer.t
    trunk/t/170-yamlish-output.t
    trunk/t/compat/test-harness-compat.t

Modified: trunk/t/020-regression.t
===================================================================
--- trunk/t/020-regression.t	2007-08-09 18:26:18 UTC (rev 213)
+++ trunk/t/020-regression.t	2007-08-09 18:38:31 UTC (rev 214)
@@ -7,7 +7,6 @@
 #use Test::More tests => 2567;
 use Test::More 'no_plan';
 use File::Spec;
-use Data::Dumper;
 
 use constant TRUE  => "__TRUE__";
 use constant FALSE => "__FALSE__";
@@ -3042,10 +3041,7 @@
                 is scalar $parser->$method(), scalar @$answer,
                   "... and $method should be the correct amount ($test)";
                 is_deeply [ $parser->$method() ], $answer,
-                  "...... and the correct values ($test)"
-                  or
-                  diag +Data::Dumper->Dump( [ [ $parser->$method() ], $answer ],
-                    [ '*got', '*expected' ] );
+                  "...... and the correct values ($test)";
             }
         }
     }

Modified: trunk/t/150-yamlish.t
===================================================================
--- trunk/t/150-yamlish.t	2007-08-09 18:26:18 UTC (rev 213)
+++ trunk/t/150-yamlish.t	2007-08-09 18:38:31 UTC (rev 214)
@@ -1,6 +1,5 @@
 use strict;
 use Test::More;
-use Data::Dumper;
 
 use TAP::Parser::YAMLish::Reader;
 
@@ -485,16 +484,6 @@
     ok my $yaml = TAP::Parser::YAMLish::Reader->new, "$name: Created";
     isa_ok $yaml, 'TAP::Parser::YAMLish::Reader';
 
-    #     diag "$name\n";
-
-    # unless ( $test->{in} ) {
-    #     pass for 1 .. 2;
-    #     use YAML;
-    #     diag "Input for test:\n";
-    #     diag( Dump( $test->{out} ) );
-    #     next;
-    # }
-
     my $source = join( "\n", @{ $test->{in} } ) . "\n";
 
     my $iter = iter( $test->{in} );
@@ -514,11 +503,7 @@
         unless ( ok !$@, "$name: No error" ) {
             diag "Error: $@\n";
         }
-        unless ( is_deeply $got, $want, "$name: Result matches" ) {
-            local $Data::Dumper::Useqq = $Data::Dumper::Useqq = 1;
-            diag( Data::Dumper->Dump( [$got],  ['$got'] ) );
-            diag( Data::Dumper->Dump( [$want], ['$expected'] ) );
-        }
+        is_deeply $got, $want, "$name: Result matches";
         is $raw, $source, "$name: Captured source matches";
     }
 }

Modified: trunk/t/160-yamlish-writer.t
===================================================================
--- trunk/t/160-yamlish-writer.t	2007-08-09 18:26:18 UTC (rev 213)
+++ trunk/t/160-yamlish-writer.t	2007-08-09 18:38:31 UTC (rev 214)
@@ -2,7 +2,6 @@
 
 use strict;
 use Test::More;
-use Data::Dumper;
 use TAP::Parser::YAMLish::Reader;
 use TAP::Parser::YAMLish::Writer;
 
@@ -209,11 +208,7 @@
         unless ( ok !$@, "$name: No error" ) {
             diag "Error: $@\n";
         }
-        unless ( is_deeply $got, $want, "$name: Result matches" ) {
-            local $Data::Dumper::Useqq = $Data::Dumper::Useqq = 1;
-            diag( Data::Dumper->Dump( [$got],  ['$got'] ) );
-            diag( Data::Dumper->Dump( [$want], ['$expected'] ) );
-        }
+        is_deeply $got, $want, "$name: Result matches";
 
         my $yr = TAP::Parser::YAMLish::Reader->new;
 
@@ -221,11 +216,7 @@
         my $reader = sub { shift @$got };
         my $parsed = $yr->read($reader);
 
-        unless ( is_deeply $parsed, $data, "$name: Reparse OK" ) {
-            local $Data::Dumper::Useqq = $Data::Dumper::Useqq = 1;
-            diag( Data::Dumper->Dump( [$parsed], ['$parsed'] ) );
-            diag( Data::Dumper->Dump( [$data],   ['$data'] ) );
-        }
+        is_deeply $parsed, $data, "$name: Reparse OK";
     }
 }
 

Modified: trunk/t/170-yamlish-output.t
===================================================================
--- trunk/t/170-yamlish-output.t	2007-08-09 18:26:18 UTC (rev 213)
+++ trunk/t/170-yamlish-output.t	2007-08-09 18:38:31 UTC (rev 214)
@@ -1,6 +1,5 @@
 use strict;
 use Test::More tests => 9;
-use Data::Dumper;
 
 use TAP::Parser::YAMLish::Writer;
 
@@ -98,9 +97,5 @@
 
     $yaml->write($in, $dest->{destination});
     my $got = $dest->{normalise}->();
-    unless ( is_deeply $got, $out, "$name: Result matches" ) {
-        local $Data::Dumper::Useqq = $Data::Dumper::Useqq = 1;
-        diag( Data::Dumper->Dump( [$got], ['$got'] ) );
-        diag( Data::Dumper->Dump( [$out], ['$expected'] ) );
-    }
+    is_deeply $got, $out, "$name: Result matches";
 }

Modified: trunk/t/compat/test-harness-compat.t
===================================================================
--- trunk/t/compat/test-harness-compat.t	2007-08-09 18:26:18 UTC (rev 213)
+++ trunk/t/compat/test-harness-compat.t	2007-08-09 18:38:31 UTC (rev 214)
@@ -746,15 +746,6 @@
 
 plan tests => $num_tests;
 
-sub is_deeply_dump($$$) {
-    my ( $got, $expect, $msg ) = @_;
-    use Data::Dumper;
-    unless ( is_deeply $got, $expect, $msg ) {
-        diag( Data::Dumper->Dump( [$got],    ['$got'] ) );
-        diag( Data::Dumper->Dump( [$expect], ['$expect'] ) );
-    }
-}
-
 sub local_name {
     my $name = shift;
     return File::Spec->catfile( split /\//, $name );
@@ -812,9 +803,9 @@
         my $lfailed = local_result( $result->{failed} );
         my $ltodo   = local_result( $result->{todo} );
 
-        is_deeply_dump $tot, $result->{totals}, "totals match for $test_key";
-        is_deeply_dump $fail, $lfailed,
+        is_deeply $tot, $result->{totals}, "totals match for $test_key";
+        is_deeply $fail, $lfailed,
           "failure summary matches for $test_key";
-        is_deeply_dump $todo, $ltodo, "todo summary matches for $test_key";
+        is_deeply $todo, $ltodo, "todo summary matches for $test_key";
     }
 }