[tapx-dev] [patch] t/080-aggregator.t
Andy Armstrong
andy at hexten.net
Wed Aug 1 22:59:42 BST 2007
On 1 Aug 2007, at 13:21, Leif Eriksen wrote:
> This is my second patch to an FOSS project, and my first was years
> ago(svn actually) so I'm not sure if I'm supposed to attach or
> inline the patch, so I flipped a coin and it said 'attach!' - lemme
> know if you want them inline from now on.
That's fine thanks. I think diff -uN (or -uNr) is the norm for
patches. That's what I always use anyway - doubtless someone will
point out I've been doing it wrong for years.
The patch looks lovely thanks. I've applied it as r203.
As a matter of interest did you find that you couldn't get coverage
information if you ran all the tests at once (make testcover)? That's
what we've been observing.
Also I notice you're not on the mailing list. I approved your address
for posting but you'll need to subscribe if you want to see all the
replies.
Thanks for the patch :)
--
Andy Armstrong, hexten.net
More information about the tapx-dev
mailing list