[tapx-dev] [patch] t/080-aggregator.t

[Leif Eriksen]

This patch to t/080-aggregator.t brings coverage of 
lib/TAP/Parser/Aggregator.pm to 100%.

The test has_problems() is a little rude - I couldn't work out how to 
get errors() and wait() to populate through TAP and API's, so I just 
jammed in description_for_XXX and XXX in the appropriate parts of the 
hash object - not very nice, but if anyone knows how to make the 
collection of the OS exits codes easier , go for it.

This is my second patch to an FOSS project, and my first was years 
ago(svn actually) so I'm not sure if I'm supposed to attach or inline 
the patch, so I flipped a coin and it said 'attach!' - lemme know if you 
want them inline from now on.

Associated output from ./Build test is

t/080-aggregator................ok
...
All tests successful.
Files=27, Tests=4694, 20 wallclock secs ( 6.74 cusr +  5.94 csys = 12.68 
CPU)

Associated output from HARNESS_PERL_SWITCHES=-MDevel::Cover ./Build test is

---------------------------- ------ ------ ------ ------ ------ ------ 
------
File                           stmt   bran   cond    sub    pod   time  
total
---------------------------- ------ ------ ------ ------ ------ ------ 
------
...
.../TAP/Parser/Aggregator.pm  100.0  100.0  100.0  100.0  100.0    1.7  
100.0
...
Total                          84.5   63.9   63.8   93.6  100.0  100.0   
80.4
---------------------------- ------ ------ ------ ------ ------ ------ 
------

I'm _very_ interested in feedback on the quality of this patch - any and 
every criticism is welcome,
don't worry, I'm an old bastard with a thick skin, let rip!! Even if you 
think the whole effort was crap, as long as you explain how I can do 
better next time...

L
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: aggregator.patch
Url: http://www.hexten.net/pipermail/tapx-dev/attachments/20070801/8e6ddb25/attachment.diff